-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] URGENT PATCH: Update run_WE2E_tests.sh #420
Conversation
EMERGENCY FIX: run_WE2E_tests.sh will not run from input tests file
Opened this PR without full message to get the tests kicked off ASAP...will update shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Machine: hera |
Machine: jet |
DESCRIPTION OF CHANGES:
PR #411 introduced new logic to allow users to specify a test_type or a test_name on the command line, in addition to the old tests_file logic which required a user to provide a file containing a lists of tests. This PR broke that old logic, so anyone using the old method to specify their own list of tests will be unable to run the end-to-end tests. The script now fails with the following error message:
The fix is a simple change from
|
(output pipe) to the intended||
(double pipe == "OR")Type of change
TESTS CONDUCTED:
Ran a random set of WE2E tests on the following platforms with the tests_file logic. While broken in the current develop, with these changes the script runs to completion.
DEPENDENCIES:
None
DOCUMENTATION:
None
ISSUE:
None