Fix #327 and #333, Squash LGTM warnings #633

skliper · 2020-10-22T21:45:31Z

Describe the contribution

Turned all FIXME comments into issues (and removed FIXME)
Fix lgtm issues for os-impl-posix-files.c, osapi-filesys.c #333: security/filename race issue resolved by opening file and acting on descriptor (had to add fstat stub)
Fix Recommended lgtm osal issues #327: squashed the minor recommended bugs

Testing performed
Built and ran unit tests, passed.

Expected behavior changes
None

System(s) tested on

Additional context
#630, #632 - new issues from FIXME
#631 - uncovered missing functional test on OS_chmod

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

astrogeco · 2020-10-28T16:16:55Z

Fix nasa#327 and nasa#333, Squash LGTM warnings

f2efc1c

skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Oct 22, 2020

skliper added this to the 6.0.0 milestone Oct 22, 2020

astrogeco added CCB-20201028 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 28, 2020

astrogeco added the IC-20201103 label Oct 30, 2020

astrogeco changed the base branch from main to integration-candidate October 30, 2020 15:45

astrogeco merged commit 0d706ca into nasa:integration-candidate Nov 2, 2020

astrogeco added a commit to nasa/cFS that referenced this pull request Nov 2, 2020

Add nasa/osal#633

bcfaacb

astrogeco mentioned this pull request Nov 3, 2020

Integration Candidate: 2020-11-03 #639

Merged

skliper deleted the fix327-lgtm-recommended branch February 1, 2021 21:36

Provide feedback