Integration Candidate: 2020-11-03 #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small edit to REVISION version comment in osapi-version.h
astrogeco
force-pushed
the
integration-candidate
branch
from
caedd24 to
2562b1f
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 4, 2020
Combines nasa/cFE#991 nasa/osal#639 nasa/PSP#213 nasa/sample_app#102 nasa/sample_lib#35 Co-authored-by: Joseph Hickey <[email protected]>
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Deletes now unused CFE_ES_CountObjectCallback and CFE_ES_ListResourcesDebug.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#639, Remove ES_APP_DEBUG functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #327 and Fix #333, Squash LGTM warnings
Fix #623, add debug messages for mutex double locks
Fix #628, Update UtAssert macros with dynamic string formatting
Testing performed
See framework-bundle CI: https://github.com/nasa/cFS/pull/154/checks
Expected behavior changes
PR #634 - When
OS_DEBUGis enabled, this adds a message if mutex give/take actions occur outside the expected sequence. This informs the user (via the debug console) if a lock is taken more than once or if a lock is given by a different task than the one that originally took it:PR #633 - No behavior changes
PR #629 - UtAssert macros now accept variable string arguments.The
UtAssert_Truewrapper around call is no longer needed to accommodate dynamic string output, thus removing the double assert. UtAssert macros will now be able to offer more information by themselves.System(s) tested on
Ubuntu CI
Additional context
nasa/cFS#154
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@agibson
@skliper