allow setting cumulus-message-adapter directory with env var #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| @@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| - Add the `CUMULUS_MESSAGE_ADAPTER_DIR` environment variable to set the path where cumulus-message-adapter is located | |||
There was a problem hiding this comment.
This should be under the ### Added section.
test/test-index-with-dir-env.js
Outdated
| @@ -0,0 +1,53 @@ | |||
| /* eslint-disable require-jsdoc */ | |||
There was a problem hiding this comment.
Add this to test/.eslintrc.json so that other test files get the same config.
marchuffnagle
suggested changes
Mar 7, 2018
|
@yjpa7145 Thanks, updated with those changes. |
marchuffnagle
previously approved these changes
Mar 8, 2018
laurenfrederick
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dependency for merging this PR and releasing the first version of cumulus-ecs-task.
This lets us set the directory where cumulus-message-adapter can be found in unusual cases where it isn't the root working directory, like in the case of cumulus-ecs-task.
This PR adds tests and updates the changelog and readme.