-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of running a lambda in ecs #1
Conversation
When given enough time, ecs service creation will fail with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made two comments.
.circleci/config.yml
Outdated
- run: | | ||
docker build -t developmentseed/cumulus:lambda-runner . | ||
docker login -u scisco -p $DOCKER_PASSWORD | ||
docker push developmentseed/cumulus:lambda-runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's push this to the cumuluss
org on docker hub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be exact, push it to: cumuluss/cumulus-ecs-task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what is our plan for versioning here? I think we should not release with latest
tag and start versioning this image.
@sethvincent the service ARN is probably not stabilized because it lacks the correct permissions. You have to make sure that your ec2 instance has the right to download the zip file of a given lambda. Also you have to make sure the base image has the latest version of python 2.7 |
This branch can now work with a couple of outside changes:
|
I've updated this with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It'd be useful to also add a CHANGELOG
This is based in part on https://git.earthdata.nasa.gov/projects/CUMULUS/repos/ecs-lambda-runner/browse
Updated to work with step function tasks using
sf.getActivityTask
and related step functions API methods.