Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #32, add lgtm file #33

Merged
merged 1 commit into from
Dec 30, 2019
Merged

issue #32, add lgtm file #33

merged 1 commit into from
Dec 30, 2019

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Dec 18, 2019

Describe the contribution
add .lgtm.yml file

Testing performed

Steps taken to test the contribution:

  1. run on lgtm against copy of cfs

Contributor Info - All information REQUIRED for consideration of pull request

Anh Van, NASA Goddard

  • Project: CFS Framework

@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Dec 18, 2019
@skliper
Copy link
Contributor

skliper commented Dec 18, 2019

CCB 20191218 - Reviewed and approved for IC

@avan989
Copy link
Contributor Author

avan989 commented Dec 23, 2019

updated to exclude switch too long, and class with too many field.
Reference: nasa/to_lab#18
nasa/cFE#442

@skliper skliper changed the base branch from master to merge-20191230 December 30, 2019 20:02
@skliper skliper merged commit 2d9612d into nasa:merge-20191230 Dec 30, 2019
skliper added a commit that referenced this pull request Dec 30, 2019
Fix #32, #34
Reviewed and approved at 2019-12-18 CCB
skliper added a commit to skliper/cFS that referenced this pull request Apr 16, 2020
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants