Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding .lgtm.yml file #32

Closed
avan989 opened this issue Dec 18, 2019 · 1 comment · Fixed by #36
Closed

Adding .lgtm.yml file #32

avan989 opened this issue Dec 18, 2019 · 1 comment · Fixed by #36
Labels
enhancement

Comments

@avan989
Copy link
Contributor

avan989 commented Dec 18, 2019

Is your feature request related to a problem? Please describe.
Add lgtm.yml file.

Requester Info
Anh Van, NASA Goddard
@skliper
Copy link
Contributor

skliper commented Dec 18, 2019

Is this ready to be a pull request? Could you also add related badges to the README?

skliper added a commit that referenced this issue Dec 30, 2019
@skliper
CCB 20191218: Merge #33 #35
b4cadfd 
Fix #32, #34
Reviewed and approved at 2019-12-18 CCB
@skliper skliper mentioned this issue Dec 31, 2019
Merged
@skliper skliper closed this as completed in 2d9612d Jan 9, 2020
chillfig pushed a commit to chillfig/cFS that referenced this issue Mar 17, 2022
@jphickey
Fix nasa#32, compile out CF_Asserts by default
743aaf3 
Changes CF_Assert to be opt-in rather than opt-out, so that under normal
verification and validation the asserts will _not_ be included, but they
can still be added back during development, if desired.

They mainly exist as notes to developers as to what is supposed to be true,
once debugged it is impossible to get these conditions, by definition.

Also removes one channel calculation that was only for assert.  Note that
the same condition is asserted later, so it was redundant anyway.
chillfig pushed a commit to chillfig/cFS that referenced this issue Mar 17, 2022
@astrogeco
Merge pull request nasa#153 from jphickey/fix-32-cf-assert-debug-only
c25b663 
Fix nasa#32, compile out CF_Asserts by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20191230 nasa/cFS
2 participants
@avan989 @skliper