Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #408, Remove device driver references in code #477

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix #408, Remove device driver references in code #477

merged 1 commit into from
Feb 25, 2020

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Jan 13, 2020

Describe the contribution
reference pull request #475

update remove reference to driver

Contributor Info - All information REQUIRED for consideration of pull request
Anh Van, NASA Goddard

@avan989 avan989 mentioned this pull request Jan 13, 2020
Closed
@skliper skliper changed the title Fix #408, new remove driver reference Fix #408, Remove device driver references in code Jan 28, 2020
skliper
skliper requested changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove changes to app dev guide (they don't look right) - separate issue #496
Remove changes to requirements - separate issue #377 (I'm working this one)
Changes to the cfe_es_apps.c, start.c and start.h don't look right (wrong lines deleted?)

@avan989 avan989 closed this Jan 28, 2020
@avan989
Copy link
Contributor Author

avan989 commented Jan 28, 2020

accidentally closed

@avan989 avan989 reopened this Jan 28, 2020
@avan989
Copy link
Contributor Author

avan989 commented Jan 28, 2020

updated.

skliper
skliper reviewed Jan 28, 2020
View reviewed changes
docs/src/cfe_es.dox Outdated Show resolved Hide resolved
@avan989
Copy link
Contributor Author

avan989 commented Jan 29, 2020

updated.

This was referenced Feb 5, 2020
Closed
Merged
@astrogeco astrogeco added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Feb 11, 2020
@astrogeco astrogeco linked an issue Feb 11, 2020 that may be closed by this pull request
Remove device driver references from code #408
Closed
@astrogeco astrogeco added this to the 6.8.0 milestone Feb 12, 2020
@astrogeco
Copy link
Contributor

CCB 20200212 - Approved

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Feb 13, 2020
@astrogeco astrogeco changed the base branch from master to ic-20200226 February 25, 2020 19:24
@astrogeco astrogeco merged commit 75558f1 into nasa:ic-20200226 Feb 25, 2020
@astrogeco astrogeco mentioned this pull request Feb 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Remove device driver references from code
3 participants
@avan989 @astrogeco @skliper