Fix #384, Update status variables (0, -1) to their defined macros
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -299,7 +299,7 @@ | |||
| if (ret == CFE_SUCCESS) | |||
| { | |||
| /* Verify CRC */ | |||
| if (CF_CFDP_R_CheckCrc(t, crc) == 0) | |||
| if (CF_CFDP_R_CheckCrc(t, crc) == CFE_SUCCESS) | |||
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression
| @@ -497,7 +497,7 @@ | |||
| /* this function is only invoked for NAK PDU types */ | |||
| nak = &ph->int_header.nak; | |||
|
|
|||
| if (CF_CFDP_RecvNak(t, ph) == 0 && nak->segment_list.num_segments > 0) | |||
| if (CF_CFDP_RecvNak(t, ph) == CFE_SUCCESS && nak->segment_list.num_segments > 0) | |||
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression
thnkslprpt
force-pushed
the
fix-384-update-status-variables-to-defined-macros
branch
from
97ceb9d to
79f7e4e
Compare
havencarlson
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
statusvariables (0, -1) can be updated to their defined macros #384status/returnvalues such as 0 and -1 have been replaced with their respective defined macros (CFE_SUCCESS,CF_ERRORetc.).Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
No change.
Improves expressiveness.
Contributor Info
Avi Weiss @thnkslprpt