Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic number status variables (0, -1) can be updated to their defined macros #384

Closed
2 tasks done
thnkslprpt opened this issue May 14, 2023 · 0 comments · Fixed by #385
Closed
2 tasks done

Magic number status variables (0, -1) can be updated to their defined macros #384

thnkslprpt opened this issue May 14, 2023 · 0 comments · Fixed by #385
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CF could use a quick clean-up of the return/status values that are still using 0 to represent success (or more specifically CFE_SUCCESS) and -1 to represent error (or more specifically CF_ERROR).

Expected behavior
Use the more expressive defined macros if they are available.

Reporter Info
Avi Weiss @thnkslprpt
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue May 14, 2023
@thnkslprpt
Fix nasa#384, Update status variables (0, -1) to their defined macros
97ceb9d
@thnkslprpt thnkslprpt mentioned this issue May 14, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue May 25, 2023
@dzbaker
Merge pull request #385 from thnkslprpt/fix-384-update-status-variabl…
0f18ae4 
…es-to-defined-macros

Fix #384, Update `status` variables (0, -1) to their defined macros
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #384, Update status variables (0, -1) to their defined macros thnkslprpt/CF
3 participants
@thnkslprpt @dmknutsen @chillfig