Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up sitemap.xml and robots.txt implementation #1355

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Sep 10, 2023

I forked https://github.com/nasa-gcn/remix-seo from https://github.com/balavishnuvj/remix-seo because the latter may be abandoned.

This PR eliminates the overriden Remix server entry point (entry.server.tsx) and instead has ordinary resource route modules for the robots.txt and sitemap.xml files.

See also balavishnuvj/remix-seo#14

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (3b53bd3) 5.64% compared to head (2ecee53) 5.75%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1355      +/-   ##
========================================
+ Coverage   5.64%   5.75%   +0.11%     
========================================
  Files        112     112              
  Lines       2606    2554      -52     
  Branches     278     273       -5     
========================================
  Hits         147     147              
+ Misses      2457    2405      -52     
  Partials       2       2              
Files Changed Coverage Δ
app/routes/$.ts 0.00% <ø> (ø)
app/routes/_auth.post_logout.tsx 0.00% <ø> (ø)
app/routes/_seo.robots[.]txt.ts 0.00% <0.00%> (ø)
app/routes/_seo.sitemap[.]xml.ts 0.00% <0.00%> (ø)
app/routes/quickstart.alerts.tsx 0.00% <ø> (ø)
app/routes/quickstart.code.tsx 0.00% <ø> (ø)
app/routes/quickstart.credentials.tsx 0.00% <ø> (ø)
app/routes/unsubscribe.$jwt/route.tsx 0.00% <ø> (ø)
app/routes/user._index.tsx 0.00% <ø> (ø)
app/routes/user.credentials._index.tsx 0.00% <ø> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger lpsinger added backend Issue relates to back-end development (API endpoints and other server-side code) seo Search engine optimization labels Sep 10, 2023
@lpsinger lpsinger marked this pull request as draft September 15, 2023 11:56
@lpsinger lpsinger force-pushed the seo-cleanup branch 2 times, most recently from ac6ba68 to 0a5bb28 Compare September 18, 2023 21:24
@lpsinger lpsinger changed the title Clean up SEO stuff Clean up sitemap.xml and robots.txt implementation Sep 18, 2023
@lpsinger lpsinger marked this pull request as ready for review September 18, 2023 21:25
I forked https://github.com/nasa-gcn/remix-seo from
https://github.com/balavishnuvj/remix-seo because the latter may
be abandoned.

This PR eliminates the overriden Remix server entry point
(`entry.server.tsx`) and instead has ordinary resource route
modules for the robots.txt and sitemap.xml files.

See also balavishnuvj/remix-seo#14
@lpsinger lpsinger merged commit dba312f into nasa-gcn:main Sep 19, 2023
@lpsinger lpsinger deleted the seo-cleanup branch September 19, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issue relates to back-end development (API endpoints and other server-side code) seo Search engine optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant