Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume route manifest from server build instead of context #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpsinger
Copy link
Contributor

Perhaps surprisingly, you can import the server build in any route module, like this:

import * as build from '@remix-run/dev/server-build'
import { useLoaderData } from '@remix-run/react'

export function loader() {
  return Object.keys(build.routes)
}

export default function () {
  const routes = useLoaderData<typeof loader>()
  return (
    <>
      <h1>List of routes</h1>
      <ul>
        {routes.map((route) => (
          <li key={route}>{route}</li>
        ))}
      </ul>
    </>
  )
}

As a result, customizing the Remix server entry point is not necessary.

See remix-run/remix#2912 (comment)

Perhaps surprisingly, you can import the server build in any route
module, like this:

```ts
import * as build from '@remix-run/dev/server-build'
import { useLoaderData } from '@remix-run/react'

export function loader() {
  return Object.keys(build.routes)
}

export default function () {
  const routes = useLoaderData<typeof loader>()
  return (
    <>
      <h1>List of routes</h1>
      <ul>
        {routes.map((route) => (
          <li key={route}>{route}</li>
        ))}
      </ul>
    </>
  )
}
```

As a result, customizing the Remix server entry point is not necessary.

See remix-run/remix#2912 (comment)
lpsinger added a commit to lpsinger/remix-seo that referenced this pull request Sep 18, 2023
Perhaps surprisingly, you can import the server build in any route
module, like this:

```ts
import * as build from '@remix-run/dev/server-build'
import { useLoaderData } from '@remix-run/react'

export function loader() {
  return Object.keys(build.routes)
}

export default function () {
  const routes = useLoaderData<typeof loader>()
  return (
    <>
      <h1>List of routes</h1>
      <ul>
        {routes.map((route) => (
          <li key={route}>{route}</li>
        ))}
      </ul>
    </>
  )
}
```

As a result, customizing the Remix server entry point is not necessary.

See remix-run/remix#2912 (comment)

Addresses balavishnuvj#14
lpsinger added a commit to nasa-gcn/remix-seo that referenced this pull request Sep 18, 2023
Perhaps surprisingly, you can import the server build in any route
module, like this:

```ts
import * as build from '@remix-run/dev/server-build'
import { useLoaderData } from '@remix-run/react'

export function loader() {
  return Object.keys(build.routes)
}

export default function () {
  const routes = useLoaderData<typeof loader>()
  return (
    <>
      <h1>List of routes</h1>
      <ul>
        {routes.map((route) => (
          <li key={route}>{route}</li>
        ))}
      </ul>
    </>
  )
}
```

As a result, customizing the Remix server entry point is not necessary.

See remix-run/remix#2912 (comment)

Addresses balavishnuvj#14
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this pull request Sep 18, 2023
I forked https://github.com/nasa-gcn/remix-seo from
https://github.com/balavishnuvj/remix-seo because the latter may
be abandoned.

This PR eliminates the overriden Remix server entry point
(`entry.server.tsx`) and instead has ordinary resource route
modules for the robots.txt and sitemap.xml files.

See also balavishnuvj/remix-seo#14
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this pull request Sep 18, 2023
I forked https://github.com/nasa-gcn/remix-seo from
https://github.com/balavishnuvj/remix-seo because the latter may
be abandoned.

This PR eliminates the overriden Remix server entry point
(`entry.server.tsx`) and instead has ordinary resource route
modules for the robots.txt and sitemap.xml files.

See also balavishnuvj/remix-seo#14
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this pull request Sep 19, 2023
I forked https://github.com/nasa-gcn/remix-seo from
https://github.com/balavishnuvj/remix-seo because the latter may
be abandoned.

This PR eliminates the overriden Remix server entry point
(`entry.server.tsx`) and instead has ordinary resource route
modules for the robots.txt and sitemap.xml files.

See also balavishnuvj/remix-seo#14
lpsinger added a commit to nasa-gcn/gcn.nasa.gov that referenced this pull request Sep 19, 2023
I forked https://github.com/nasa-gcn/remix-seo from
https://github.com/balavishnuvj/remix-seo because the latter may
be abandoned.

This PR eliminates the overriden Remix server entry point
(`entry.server.tsx`) and instead has ordinary resource route
modules for the robots.txt and sitemap.xml files.

See also balavishnuvj/remix-seo#14
Vidushi-GitHub pushed a commit to Vidushi-GitHub/gcn.nasa.gov that referenced this pull request Oct 11, 2023
I forked https://github.com/nasa-gcn/remix-seo from
https://github.com/balavishnuvj/remix-seo because the latter may
be abandoned.

This PR eliminates the overriden Remix server entry point
(`entry.server.tsx`) and instead has ordinary resource route
modules for the robots.txt and sitemap.xml files.

See also balavishnuvj/remix-seo#14
@lpsinger
Copy link
Contributor Author

Note: this has a conflict due to #9. I suggest merging #12 first to resolve the conflict.

lpsinger pushed a commit to lpsinger/remix-seo that referenced this pull request Jun 25, 2024
Use Node 20 for publish workflow; Node 16 is EOL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant