-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume route manifest from server build instead of context #14
Open
lpsinger
wants to merge
1
commit into
balavishnuvj:main
Choose a base branch
from
lpsinger:server-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps surprisingly, you can import the server build in any route module, like this: ```ts import * as build from '@remix-run/dev/server-build' import { useLoaderData } from '@remix-run/react' export function loader() { return Object.keys(build.routes) } export default function () { const routes = useLoaderData<typeof loader>() return ( <> <h1>List of routes</h1> <ul> {routes.map((route) => ( <li key={route}>{route}</li> ))} </ul> </> ) } ``` As a result, customizing the Remix server entry point is not necessary. See remix-run/remix#2912 (comment)
lpsinger
added a commit
to lpsinger/remix-seo
that referenced
this pull request
Sep 18, 2023
Perhaps surprisingly, you can import the server build in any route module, like this: ```ts import * as build from '@remix-run/dev/server-build' import { useLoaderData } from '@remix-run/react' export function loader() { return Object.keys(build.routes) } export default function () { const routes = useLoaderData<typeof loader>() return ( <> <h1>List of routes</h1> <ul> {routes.map((route) => ( <li key={route}>{route}</li> ))} </ul> </> ) } ``` As a result, customizing the Remix server entry point is not necessary. See remix-run/remix#2912 (comment) Addresses balavishnuvj#14
lpsinger
added a commit
to nasa-gcn/remix-seo
that referenced
this pull request
Sep 18, 2023
Perhaps surprisingly, you can import the server build in any route module, like this: ```ts import * as build from '@remix-run/dev/server-build' import { useLoaderData } from '@remix-run/react' export function loader() { return Object.keys(build.routes) } export default function () { const routes = useLoaderData<typeof loader>() return ( <> <h1>List of routes</h1> <ul> {routes.map((route) => ( <li key={route}>{route}</li> ))} </ul> </> ) } ``` As a result, customizing the Remix server entry point is not necessary. See remix-run/remix#2912 (comment) Addresses balavishnuvj#14
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
Sep 18, 2023
I forked https://github.com/nasa-gcn/remix-seo from https://github.com/balavishnuvj/remix-seo because the latter may be abandoned. This PR eliminates the overriden Remix server entry point (`entry.server.tsx`) and instead has ordinary resource route modules for the robots.txt and sitemap.xml files. See also balavishnuvj/remix-seo#14
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
Sep 18, 2023
I forked https://github.com/nasa-gcn/remix-seo from https://github.com/balavishnuvj/remix-seo because the latter may be abandoned. This PR eliminates the overriden Remix server entry point (`entry.server.tsx`) and instead has ordinary resource route modules for the robots.txt and sitemap.xml files. See also balavishnuvj/remix-seo#14
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
Sep 19, 2023
I forked https://github.com/nasa-gcn/remix-seo from https://github.com/balavishnuvj/remix-seo because the latter may be abandoned. This PR eliminates the overriden Remix server entry point (`entry.server.tsx`) and instead has ordinary resource route modules for the robots.txt and sitemap.xml files. See also balavishnuvj/remix-seo#14
lpsinger
added a commit
to nasa-gcn/gcn.nasa.gov
that referenced
this pull request
Sep 19, 2023
I forked https://github.com/nasa-gcn/remix-seo from https://github.com/balavishnuvj/remix-seo because the latter may be abandoned. This PR eliminates the overriden Remix server entry point (`entry.server.tsx`) and instead has ordinary resource route modules for the robots.txt and sitemap.xml files. See also balavishnuvj/remix-seo#14
Vidushi-GitHub
pushed a commit
to Vidushi-GitHub/gcn.nasa.gov
that referenced
this pull request
Oct 11, 2023
I forked https://github.com/nasa-gcn/remix-seo from https://github.com/balavishnuvj/remix-seo because the latter may be abandoned. This PR eliminates the overriden Remix server entry point (`entry.server.tsx`) and instead has ordinary resource route modules for the robots.txt and sitemap.xml files. See also balavishnuvj/remix-seo#14
lpsinger
pushed a commit
to lpsinger/remix-seo
that referenced
this pull request
Jun 25, 2024
Use Node 20 for publish workflow; Node 16 is EOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps surprisingly, you can import the server build in any route module, like this:
As a result, customizing the Remix server entry point is not necessary.
See remix-run/remix#2912 (comment)