-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the argmin and argmax function expr.py file and series.py file #1496
Closed
MUKESHRAJMAHENDRAN
wants to merge
6
commits into
narwhals-dev:main
from
MUKESHRAJMAHENDRAN:feat/1492-series-expr-argmin-argmax
+488
β0
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7f939c6
Added the argmin and argmax function expr.py file and series.py file
MUKESHRAJMAHENDRAN e5e87a0
Added the test for max
MUKESHRAJMAHENDRAN 2067aa4
Added the test for exp max, min and series max, min
MUKESHRAJMAHENDRAN fc387b1
Added the test for exp max, min and series max, min
MUKESHRAJMAHENDRAN 0e5cf1a
Added the test for exp max, min and series max, min
MUKESHRAJMAHENDRAN acfc6e9
Still the test case is failing
MUKESHRAJMAHENDRAN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,8 @@ | |
- diff | ||
- drop_nulls | ||
- ewm_mean | ||
- arg_min | ||
- arg_max | ||
- fill_null | ||
- filter | ||
- gather_every | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,8 @@ | |
- max | ||
- mean | ||
- median | ||
- arg_min | ||
- arg_max | ||
- min | ||
- mode | ||
- name | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should be sorted alphabetically