Added the argmin and argmax function expr.py file and series.py file #1496
+488
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
reviewed
Dec 3, 2024
docs/api-reference/expr.md
Outdated
Comment on lines
22
to
23
| - arg_min | ||
| - arg_max |
There was a problem hiding this comment.
these should be sorted alphabetically
|
hey - i'd suggest reading through https://narwhals-dev.github.io/narwhals/how_it_works/, i get the impression that this PR is involving a lot of guesswork |
|
Thanks, yup Mostly going through the flow thanks for the suggestion i will go through it and try to understand. |
|
Hi, I am going through the code lost myself, please guide me what is the mistake i am doing now, how should i correct it where is the issue. So i can understand the codebase better. |
|
i'd suggest looking at similar functions and understanding how they're implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below