Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Php 7.1 version #91

Merged
merged 4 commits into from
Nov 2, 2018
Merged

Php 7.1 version #91

merged 4 commits into from
Nov 2, 2018

Conversation

prisis
Copy link
Member

@prisis prisis commented Nov 2, 2018

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #92,fixes #93
License MIT
Doc PR -

prisis and others added 3 commits October 12, 2018 14:19
| Q               | A
| --------------- | ---
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | -
| License         | MIT
| Doc PR          | -
changed min version of php to 7.1
added php 7.1 and 7.3 to travis
@prisis prisis changed the title Php 71 version Php 7.1 version Nov 2, 2018
@prisis prisis added Added Changelog Added Changed Changelog Changed labels Nov 2, 2018
@prisis prisis added this to the v0.9.0 milestone Nov 2, 2018
@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #91 into master will increase coverage by 0.53%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #91      +/-   ##
============================================
+ Coverage     70.38%   70.91%   +0.53%     
- Complexity      801      812      +11     
============================================
  Files            53       54       +1     
  Lines          2134     2180      +46     
============================================
+ Hits           1502     1546      +44     
- Misses          632      634       +2
Impacted Files Coverage Δ Complexity Δ
src/Security/SecurityPlugin.php 84.12% <ø> (ø) 25 <0> (ø) ⬇️
src/Common/ScriptExtender/PhpScriptExtender.php 84.61% <ø> (-15.39%) 6 <0> (ø)
src/Common/Installer/Installer.php 100% <ø> (ø) 10 <0> (+2) ⬆️
src/Automatic/Automatic.php 58.65% <0%> (ø) 132 <0> (ø) ⬇️
src/Automatic/Installer/InstallationManager.php 0% <0%> (ø) 19 <0> (ø) ⬇️
...utomatic/Configurator/Traits/AppendToFileTrait.php 100% <100%> (ø) 5 <5> (?)
src/Common/Configurator/AbstractConfigurator.php 100% <100%> (ø) 7 <0> (ø) ⬇️
...matic/Configurator/ComposerScriptsConfigurator.php 100% <100%> (ø) 22 <0> (ø) ⬇️
src/Automatic/ScriptExecutor.php 100% <100%> (ø) 12 <0> (ø) ⬇️
...c/Configurator/ComposerAutoScriptsConfigurator.php 100% <100%> (ø) 7 <0> (ø) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a50e9...125468c. Read the comment docs.

@prisis prisis removed Added Changelog Added Changed Changelog Changed labels Nov 2, 2018
@prisis prisis removed this from the v0.9.0 milestone Nov 2, 2018
@prisis prisis merged commit aa853e0 into narrowspark:master Nov 2, 2018
@prisis prisis deleted the php-71-version branch November 2, 2018 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade coding-standard to v1.4.0 changed min version of php to 7.1
1 participant