Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

changed \n to PHP_EOL #89

Merged
merged 13 commits into from
Oct 12, 2018
Merged

changed \n to PHP_EOL #89

merged 13 commits into from
Oct 12, 2018

Conversation

prisis
Copy link
Member

@prisis prisis commented Oct 10, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT
Doc PR -

@prisis prisis added the Changed Changelog Changed label Oct 10, 2018
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #89 into master will decrease coverage by 0.06%.
The diff coverage is 76.31%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     70.38%   70.32%   -0.07%     
- Complexity      801      809       +8     
============================================
  Files            53       54       +1     
  Lines          2134     2153      +19     
============================================
+ Hits           1502     1514      +12     
- Misses          632      639       +7
Impacted Files Coverage Δ Complexity Δ
src/Automatic/Automatic.php 58.65% <0%> (ø) 132 <0> (ø) ⬇️
src/Automatic/Installer/InstallationManager.php 0% <0%> (ø) 19 <0> (ø) ⬇️
...c/Configurator/ComposerAutoScriptsConfigurator.php 100% <100%> (ø) 7 <0> (ø) ⬇️
src/Common/Traits/PhpFileMarkerTrait.php 100% <100%> (ø) 3 <0> (ø) ⬇️
src/Automatic/SkeletonGenerator.php 100% <100%> (ø) 15 <0> (ø) ⬇️
src/Automatic/Configurator/EnvConfigurator.php 100% <100%> (ø) 15 <0> (ø) ⬇️
src/Automatic/QuestionFactory.php 100% <100%> (ø) 8 <0> (ø) ⬇️
...c/Automatic/Configurator/GitIgnoreConfigurator.php 100% <100%> (ø) 7 <0> (+3) ⬆️
src/Common/Configurator/AbstractConfigurator.php 100% <100%> (ø) 7 <0> (ø) ⬇️
src/Security/Command/Formatter/SimpleFormatter.php 100% <100%> (ø) 6 <0> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a50e9...395707b. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #89 into master will increase coverage by 0.5%.
The diff coverage is 94.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #89     +/-   ##
===========================================
+ Coverage     70.38%   70.89%   +0.5%     
- Complexity      801      811     +10     
===========================================
  Files            53       54      +1     
  Lines          2134     2178     +44     
===========================================
+ Hits           1502     1544     +42     
- Misses          632      634      +2
Impacted Files Coverage Δ Complexity Δ
src/Common/ScriptExtender/PhpScriptExtender.php 84.61% <ø> (-15.39%) 6 <0> (ø)
src/Common/Installer/Installer.php 100% <ø> (ø) 10 <0> (+2) ⬆️
src/Automatic/Automatic.php 58.65% <0%> (ø) 132 <0> (ø) ⬇️
src/Automatic/Installer/InstallationManager.php 0% <0%> (ø) 19 <0> (ø) ⬇️
...c/Automatic/Configurator/GitIgnoreConfigurator.php 100% <100%> (ø) 7 <0> (+3) ⬆️
...utomatic/Configurator/Traits/AppendToFileTrait.php 100% <100%> (ø) 5 <5> (?)
src/Common/Configurator/AbstractConfigurator.php 100% <100%> (ø) 7 <0> (ø) ⬇️
...matic/Configurator/ComposerScriptsConfigurator.php 100% <100%> (ø) 22 <0> (ø) ⬇️
src/Automatic/ScriptExecutor.php 100% <100%> (ø) 12 <0> (ø) ⬇️
...c/Configurator/ComposerAutoScriptsConfigurator.php 100% <100%> (ø) 7 <0> (ø) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a50e9...395707b. Read the comment docs.

@prisis prisis merged commit be4f6a3 into master Oct 12, 2018
@prisis prisis deleted the change-n-to-PHP_EOL branch October 12, 2018 12:19
@prisis prisis added this to the v0.8.6 milestone Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changed Changelog Changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants