Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on milestones for PRs #221

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Add note on milestones for PRs #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79cd199
Add note on milestones for PRs
melissawm Aug 8, 2023
2b0cf45
Add note about labels and milestone CI check
melissawm Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/developers/core_dev_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ should be covered by at least one test. Good tests not only execute the code,
but explore corner cases. It can be tempting not to review tests, but please
do so.

7. **Labels and Milestones:** Make sure you add the appropriate labels and
milestone to PRs before merging. This should be done both in the main napari
repo and in the docs repo. Both repos have a CI check, triggered by the
`ready_to_merge` label, which will fail if the milestone is not set in the PR.

Other changes may be *nitpicky*: spelling mistakes, formatting,
etc. Do not insist contributors make these changes, but instead you should offer
to make these changes by [pushing to their branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork), or using GitHub’s [suggestion](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request)
Expand Down