Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note on milestones for PRs #221

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Add note on milestones for PRs #221

merged 2 commits into from
Sep 14, 2023

Conversation

melissawm
Copy link
Member

Description

Adds a small note on adding milestones to PRs. If this is not useful, feel free to close!

Type of change

  • Fixes or improves existing content
  • Adds new content page(s)
  • Fixes or improves workflow, documentation build or deployment

References

--

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 8, 2023
psobolewskiPhD
psobolewskiPhD approved these changes Sep 1, 2023
View reviewed changes
docs/developers/core_dev_guide.md Outdated Show resolved Hide resolved
@psobolewskiPhD psobolewskiPhD added this to the 0.4.19 milestone Sep 2, 2023
@brisvag
Copy link
Contributor

brisvag commented Sep 4, 2023

We should add that this check is triggered by the ready_to_merge label, so adding that is a pretty important step now.

@melissawm
Copy link
Member Author

How about this wording?

@psobolewskiPhD psobolewskiPhD merged commit 1f04a50 into napari:main Sep 14, 2023
@melissawm melissawm deleted the milestones-note branch January 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

@brisvag brisvag brisvag approved these changes

Assignees

@melissawm melissawm

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.4.19
Development

Successfully merging this pull request may close these issues.
3 participants
@melissawm @brisvag @psobolewskiPhD