Removing static initialization of nano::network_params#3413

Merged

clemahieu merged 17 commits intodevelopfrom network_params_ref

Aug 6, 2021

+369-426

Commits on Aug 1, 2021

Commits on Aug 3, 2021

Removing unnecessary checks for is_dev_network in confirmation height process and remove the subsequently unused instance of nano::network_params that was instantiated statically.
clemahieu
committed
Rewrite reset_confirmation_heights to use a reference to ledger_constants
clemahieu
committed
Converting node_id_handshake from unnecessarily using channel::send_buffer to using channel::send
clemahieu
committed
Removing the version_min_m member from nano::message_header as unnecessary. Serializing this version number to/from the message_header the same as the other two version_max and version_using.
clemahieu
committed
Passing nano::protocol_constants in to message_parser rather than referencing it statically.
clemahieu
committed
Sending message via nano::channel::send rather than directly via send_buffer.
clemahieu
committed
Moving message header version assignment to nano::channel::send rather than on message header construction. This separates the assignment of protocol-specific information, specifically the version …
clemahieu
committed
Removing unused variables.
clemahieu
committed
Removing unused references to nano::network_params and replacing a statically instantiated dev network params with the version available in the nano::dev namespace.
clemahieu
committed
Replacing static network_params with a default inactive node.
clemahieu
committed

Commits on Aug 4, 2021

Commits on Aug 5, 2021