Removing static initialization of nano::network_params #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce to network_params.
… process and remove the subsequently unused instance of nano::network_params that was instantiated statically.
…uffer to using channel::send
…ssary. Serializing this version number to/from the message_header the same as the other two version_max and version_using.
…erencing it statically.
…r than on message header construction. This separates the assignment of protocol-specific information, specifically the version numbers, from the logic of creating messages.
…atically instantiated dev network params with the version available in the nano::dev namespace.
…instantiation of network parameters to test if a state block is an epoch.
…c information to determine network.
zhyatt
added
the
quality improvements
thsfs
previously approved these changes
Aug 4, 2021
dsiganos
reviewed
Aug 4, 2021
…work_constants in order to eliminate guesswork of setting these values before serializing.
dsiganos
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of commits to remove static instantiation of nano::network_params. Static initialization is a bad practice in general and prevents more complex configurations, hindered config reloading, and is generally counterintuitive.