Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve delegators rpc by adding "count", "start", and "threshold" parameters (#3330) #3333

Merged
merged 16 commits into from
Jun 15, 2021
Merged

Improve delegators rpc by adding "count", "start", and "threshold" parameters (#3330) #3333

merged 16 commits into from
Jun 15, 2021

Conversation

shryder
Copy link
Contributor

@shryder shryder commented Jun 13, 2021

No description provided.

shryder added 8 commits June 12, 2021 07:41
@shryder
Add "count" and "offset" parameters to "delegators" RPC (nanocurrency…
d42b097 
…#3330)
@shryder
Add "threshold" parameter to "delegators" RPC (nanocurrency#3330)
0188fc8
@shryder
Add "head" parameter to "delegators" RPC and remove "offset" (nanocur…
1362d11 
…rency#330)
@shryder
Add "head" parameter to "delegators" RPC and remove "offset" (nanocur…
7ed70d6 
…rency#3330)
@shryder
Merge remote-tracking branch 'origin/improve_delegators_rpc' into imp…
d306068 
…rove_delegators_rpc
@shryder
No need to check for availability of the head account (nanocurrency#3330
262ede8 
)
@shryder
Add "count", "head" and "threshold" parameters to "delegators" RPC (n…
dee5ee8 
…anocurrency#3330)
@shryder
Merge branch 'improve_delegators_rpc' of https://github.com/Shryder/n…
0c12473 
…ano-node into improve_delegators_rpc
@clemahieu clemahieu requested a review from SergiySW June 13, 2021 18:27
@shryder shryder changed the title Improve delegators rpc by adding "count", "head", and "delegators" parameters Improve delegators rpc by adding "count", "head", and "delegators" parameters (#3330) Jun 13, 2021
@shryder shryder changed the title Improve delegators rpc by adding "count", "head", and "delegators" parameters (#3330) Improve delegators rpc by adding "count", "head", and "threshold" parameters (#3330) Jun 13, 2021
@SergiySW SergiySW added the rpc Changes related to Remote Procedure Calls label Jun 14, 2021
@SergiySW SergiySW added this to the V23.0 milestone Jun 14, 2021
SergiySW
SergiySW previously approved these changes Jun 15, 2021
View reviewed changes
@SergiySW SergiySW added the documentation This item indicates the need for or supplies updated or expanded documentation label Jun 15, 2021
@SergiySW
Copy link
Contributor

@shryder I included small test rpc.delegators_parameters if you don't mind

@clemahieu clemahieu merged commit d6dfeaf into nanocurrency:develop Jun 15, 2021
@shryder shryder mentioned this pull request Oct 29, 2021
Closed
@zhyatt zhyatt mentioned this pull request Nov 23, 2021
Closed
@zhyatt zhyatt changed the title Improve delegators rpc by adding "count", "head", and "threshold" parameters (#3330) Improve delegators rpc by adding "count", "start", and "threshold" parameters (#3330) Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu left review comments

@dstnbrkr dstnbrkr dstnbrkr left review comments

@SergiySW SergiySW SergiySW approved these changes

Assignees
No one assigned
Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls
Projects
None yet
Milestone
V23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shryder @SergiySW @dstnbrkr @clemahieu