Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating include_only_confirmed defaults on applicable RPCs #551

Merged
merged 4 commits into from
Jul 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions docs/commands/rpc-protocol.md
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,7 @@ Returns a list of pairs of account and block hash representing the head block fo
---

### accounts_pending
Returns a list of block hashes which have not yet been received by these **accounts**

--8<-- "rpc_include_only_confirmed_recommended.md"
Returns a list of confirmed block hashes which have not yet been received by these **accounts**

**Request:**
```json
Expand Down Expand Up @@ -457,7 +455,7 @@ Boolean, false by default. Additionally sorts each account's blocks by their amo
**Optional "include_only_confirmed"**

_version 19.0+_
Boolean, false by default. Only returns blocks which have their confirmation height set or are undergoing confirmation height processing.
Boolean, true by default (_version 22.0+_), previously false by default. Only returns blocks which have their confirmation height set or are undergoing confirmation height processing. If false, unconfirmed blocks will also be returned.

---

Expand Down Expand Up @@ -1771,8 +1769,6 @@ _version 20.0 will generate the node_id with `node_` prefix, earlier versions wi
### pending
Returns a list of block hashes which have not yet been received by this account.

--8<-- "rpc_include_only_confirmed_recommended.md"

**Request:**
```json
{
Expand Down Expand Up @@ -1868,7 +1864,7 @@ If used with "count" only sorts relative to the first pending entries found up t
**Optional "include_only_confirmed"**

_version 19.0+_
Boolean, false by default. Only returns block which have their confirmation height set or are undergoing confirmation height processing.
Boolean, true by default (_version 22.0+_), previously false by default. Only returns blocks which have their confirmation height set or are undergoing confirmation height processing. If false, unconfirmed blocks will also be returned.

---

Expand Down Expand Up @@ -1907,7 +1903,7 @@ Boolean, false by default. Include active blocks without finished confirmations
**Optional "include_only_confirmed"**

_version 19.0+_
Boolean, false by default. Only returns hashes which have their confirmation height set or are undergoing confirmation height processing.
BBoolean, true by default (_version 22.0+_), previously false by default. Only returns blocks which have their confirmation height set or are undergoing confirmation height processing. If false, unconfirmed blocks will also be returned.

---

Expand Down Expand Up @@ -3970,8 +3966,8 @@ Boolean, false by default. Returns the minimum version (epoch) of a block which

**Optional "include_only_confirmed"**

_version 19.0+_
Boolean, false by default. Only returns block which have their confirmation height set or are undergoing confirmation height processing.
_version 19.0+_
Boolean, true by default (_version 22.0+_), previously false by default. Only returns blocks which have their confirmation height set or are undergoing confirmation height processing. If false, unconfirmed blocks will also be returned.

---

Expand Down
3 changes: 1 addition & 2 deletions docs/integration-guides/key-management.md
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,7 @@ curl -d '{
"action": "pending",
"account": "nano_1rawdji18mmcu9psd6h87qath4ta7iqfy8i4rqi89sfdwtbcxn57jm9k3q11",
"count": "1",
"sorting": "true",
"include_only_confirmed": "true"
"sorting": "true"
}' http://127.0.0.1:7076
```

Expand Down
4 changes: 0 additions & 4 deletions docs/snippets/rpc_include_only_confirmed_recommended.md

This file was deleted.