Updating include_only_confirmed defaults on applicable RPCs #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
reviewed
Jul 23, 2021
docs/commands/rpc-protocol.md
Outdated
| @@ -457,7 +455,7 @@ Boolean, false by default. Additionally sorts each account's blocks by their amo | |||
| **Optional "include_only_confirmed"** | |||
|
|
|||
| _version 19.0+_ | |||
| Boolean, false by default. Only returns blocks which have their confirmation height set or are undergoing confirmation height processing. | |||
| Boolean, true by default. Only returns blocks which have their confirmation height set or are undergoing confirmation height processing. If false, unconfirmed blocks will also be returned. | |||
There was a problem hiding this comment.
It is true by default, from v22 onwards only.
There was a problem hiding this comment.
Updated in all locations that appeared to exist in V19 and default updated in V22
dsiganos
approved these changes
Jul 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527
Might still need adjustment to
include_activeparameter details, but can also be done in separate PR.