Develop/develop #96
Merged
Develop/develop #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[chore] Fixed image name
…st-process Feature/frontend/post process
…ak-off Feature/backend/break off
…tter [WIP] wip
…itter [add] Changing communication method.
…itter [chenge] try new icon
…tter [WIP] wip
…tter [feat] Post on Twitter
…itter [change] Add icon and adjust button position
Develop/twitter
…itter [update] Modify design.
[change] Changed tweet text
[fix] Fixed a bug
…itter Feature/frontend/twitter
Develop/twitter
[docs] Changed README
nakajima-john-shotaro
added
enhancement
urasakikeisuke
requested changes
Sep 19, 2021
| @@ -296,7 +297,7 @@ def __init__( | |||
| save_mp4_path: str = os.path.join(self.client_data[JSON_MP4_PATH], "timelapse.mp4") | |||
| self.response_mp4_path: str = save_mp4_path.replace("frontend/", "") | |||
|
|
|||
| self.writer: imageio.core.Format.Writer = get_writer(save_mp4_path, fps=10) | |||
| self.writer: imageio.core.Format.Writer = get_writer(save_mp4_path, fps=20, quality=10) | |||
There was a problem hiding this comment.
Suggested change
| self.writer: imageio.core.Format.Writer = get_writer(save_mp4_path, fps=20, quality=10) | |
| self.writer: imageio.core.Format.Writer = get_writer(save_mp4_path, fps=20) |
| @@ -265,7 +265,7 @@ def __init__( | |||
| save_mp4_path: str = os.path.join(self.client_data[JSON_MP4_PATH], "timelapse.mp4") | |||
| self.response_mp4_path: str = save_mp4_path.replace("frontend/", "") | |||
|
|
|||
| self.writer: imageio.core.Format.Writer = get_writer(save_mp4_path, fps=10) | |||
| self.writer: imageio.core.Format.Writer = get_writer(save_mp4_path, fps=20, quality=10) | |||
There was a problem hiding this comment.
Suggested change
| self.writer: imageio.core.Format.Writer = get_writer(save_mp4_path, fps=20, quality=10) | |
| self.writer: imageio.core.Format.Writer = get_writer(save_mp4_path, fps=20) |
[change] remove unneed code
urasakikeisuke
approved these changes
Sep 19, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
fix: (bug fix for the user, not a fix to a build script)change: (simple fix for a non-critical issue)feat: (new feature for the user, not a new feature for build script)docs: (changes to the documentation)refactor: (refactoring production code, eg. renaming a variable)style: (formatting, missing semi colons, etc; no production code change)test: (adding missing tests, refactoring tests; no production code change)chore: (updating grunt tasks etc; no production code change)reverts: (canceling commits or pull requests)Description
Completed AIcon.
Pre-Review Checklist for the Pull Request Author
Checklist for the Pull Request Reviewer
Post-Review Checklist for the Pull Request Author