Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/frontend/post process #82

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Feature/frontend/post process #82

merged 2 commits into from
Sep 17, 2021

Conversation

nakajima-john-shotaro
Copy link
Owner

Pull Request Type

  • 🐛 fix : (bug fix for the user, not a fix to a build script)
  • 🩹 change : (simple fix for a non-critical issue)
  • ✨ feat : (new feature for the user, not a new feature for build script)
  • 📝 docs : (changes to the documentation)
  • ♻️ refactor : (refactoring production code, eg. renaming a variable)
  • ✏️ style : (formatting, missing semi colons, etc; no production code change)
  • 🚨 test : (adding missing tests, refactoring tests; no production code change)
  • 📦 chore : (updating grunt tasks etc; no production code change)
  • ⏪ reverts : (canceling commits or pull requests)

Description

brush up.

Pre-Review Checklist for the Pull Request Author

  • Code follows coding-guidelines
  • Assign Pull Request to reviewer

Checklist for the Pull Request Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding-guidelines
  • (Optional) Unit tests have been written for new behavior
  • Pull Request title describes the changes

Post-Review Checklist for the Pull Request Author

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@nakajima-john-shotaro nakajima-john-shotaro added change Just little changes frontend Frontend related labels Sep 17, 2021
@nakajima-john-shotaro nakajima-john-shotaro self-assigned this Sep 17, 2021
@urasakikeisuke urasakikeisuke merged commit e1c641c into develop/develop Sep 17, 2021
@urasakikeisuke urasakikeisuke deleted the feature/frontend/post-process branch September 17, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urasakikeisuke urasakikeisuke urasakikeisuke approved these changes

Assignees

@nakajima-john-shotaro nakajima-john-shotaro

Labels
change Just little changes frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nakajima-john-shotaro @urasakikeisuke