Enable secret informer filtering (knative#1281) (#11)

* add label to release secrets * clean up Co-authored-by: Stavros Kontopoulos <[email protected]>
nak3 · Mar 3, 2023 · 9304534 · 9304534
1 parent b87bd91
commit 9304534
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/openshift/patches/007-secret-informer.patch b/openshift/patches/007-secret-informer.patch
@@ -0,0 +1,14 @@
+diff --git a/test/e2e/domainmapping/domain_mapping_test.go b/test/e2e/domainmapping/domain_mapping_test.go
+index 9b5c7b2d1..7f71686ce 100644
+--- a/test/e2e/domainmapping/domain_mapping_test.go
++++ b/test/e2e/domainmapping/domain_mapping_test.go
+@@ -82,7 +82,8 @@ func TestBYOCertificate(t *testing.T) {
+ 	cert, key := makeCertificateForDomain(t, host)
+ 	secret, err := clients.KubeClient.CoreV1().Secrets(test.ServingFlags.TestNamespace).Create(ctx, &corev1.Secret{
+ 		ObjectMeta: metav1.ObjectMeta{
+-			Name: test.AppendRandomString("byocert-secret"),
++			Name:   test.AppendRandomString("byocert-secret"),
++			Labels: map[string]string{"networking.internal.knative.dev/certificate-uid": "byocert-secret"},
+ 		},
+ 		Type: corev1.SecretTypeTLS,
+ 		Data: map[string][]byte{
diff --git a/test/e2e/domainmapping/domain_mapping_test.go b/test/e2e/domainmapping/domain_mapping_test.go
@@ -82,7 +82,8 @@ func TestBYOCertificate(t *testing.T) {
 	cert, key := makeCertificateForDomain(t, host)
 	secret, err := clients.KubeClient.CoreV1().Secrets(test.ServingFlags.TestNamespace).Create(ctx, &corev1.Secret{
 		ObjectMeta: metav1.ObjectMeta{
-			Name: test.AppendRandomString("byocert-secret"),
+			Name:   test.AppendRandomString("byocert-secret"),
+			Labels: map[string]string{"networking.internal.knative.dev/certificate-uid": "byocert-secret"},
 		},
 		Type: corev1.SecretTypeTLS,
 		Data: map[string][]byte{

diff --git a/third_party/kourier-latest/kourier.yaml b/third_party/kourier-latest/kourier.yaml
@@ -347,7 +347,7 @@ spec:
             - name: KOURIER_GATEWAY_NAMESPACE
               value: "kourier-system"
             - name: ENABLE_SECRET_INFORMER_FILTERING_BY_CERT_UID
-              value: "false"
+              value: "true"
           ports:
             - name: http2-xds
               containerPort: 18000