Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller logging improvements #1281

Closed
mdemirhan opened this issue Jun 19, 2018 · 0 comments
Closed

Controller logging improvements #1281

mdemirhan opened this issue Jun 19, 2018 · 0 comments
Labels
area/API API objects and controllers area/monitoring kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Well-understood/specified features, ready for coding.

Comments

@mdemirhan
Copy link
Contributor

Expected Behavior

Controller code was recently migrated to use a structured logging library. A basic structure was added to the logs as part of this work - revision, configuration, route names & namespaces are uplifted from the message into its own key value pairs. The advantage of such uplifting is that such fields can act as a filters to search within messages.

However; a detailed analysis on the current logs needs to be done and more structure to the logs should be added as appropriate. Below is a proposed guideline by @grantr to determine if something should be kept in the log message vs should be a separate key/value pair in the logs:

If a field can act as a filter key to group messages, it should be a structured log field. If a field's searchability will lead to confusion (for example, if it tends to be parsed incorrectly or is easily confused with a different field) then it should not be a structured log field. If a field's key is dynamic with high cardinality, then it should be interpolated (though in this case, the dynamic key should likely be a value itself).

@google-prow-robot google-prow-robot added area/API API objects and controllers area/monitoring kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Well-understood/specified features, ready for coding. labels Jun 19, 2018
@mdemirhan mdemirhan changed the title Controller logs Controller logging improvements Jun 19, 2018
nak3 pushed a commit to nak3/serving that referenced this issue Nov 10, 2022
* add label to release secrets

* clean up
mgencur pushed a commit to openshift-knative/serving that referenced this issue Nov 11, 2022
* add label to release secrets

* clean up
openshift-merge-robot pushed a commit to openshift-knative/serving that referenced this issue Nov 15, 2022
* add label to release secrets

* clean up

Co-authored-by: Stavros Kontopoulos <[email protected]>
openshift-merge-robot pushed a commit to openshift-knative/serving that referenced this issue Nov 18, 2022
* add label to release secrets

* clean up

Co-authored-by: Stavros Kontopoulos <[email protected]>
openshift-merge-robot pushed a commit to openshift-knative/serving that referenced this issue Dec 6, 2022
* add label to release secrets

* clean up

Co-authored-by: Stavros Kontopoulos <[email protected]>
nak3 pushed a commit to nak3/serving that referenced this issue Mar 3, 2023
* add label to release secrets

* clean up

Co-authored-by: Stavros Kontopoulos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers area/monitoring kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Development

No branches or pull requests

2 participants