Add Content model and list display #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8chur
requested changes
Jan 21, 2019
| /** | ||
| It's not a side project if you can't have some fun, right? | ||
| - [Original.](https://www.youtube.com/watch?v=amONEHAhLHY) | ||
| - [Crispy.](https://www.youtube.com/watch?v=1BC1G33-fNY) |
|
@n8chur PR updated |
n8chur
reviewed
Jan 24, 2019
| private let spacingView: UIView = { | ||
| let view = UIView() | ||
| view.snp.makeConstraints { $0.height.equalTo(35) } | ||
| return view |
There was a problem hiding this comment.
Rather than having a spacing view, could we have two UIStackViews inside of an outer UIStackView, then just give that UIStackView the appropriate spacing value? If we build it this way, we could even easily use a theme to define the spacing.
| .joined(separator: ", ") | ||
| } | ||
| return Property(observable, initial: "") | ||
| }() |
|
@n8chur PR updated |
|
@n8chur CI failure possibly related to microsoft/azure-pipelines-tasks#8840? |
@lokae0: Yup, pretty sure it’s the same issue. Doesn’t look like anyone’s found a solution yet ¯_(ツ)_/¯ Sent with GitHawk |
lokae0
added a commit
that referenced
this pull request
Jan 28, 2019
* Abstract centered label, remove unnecessary button boilerplate, and add spacing view * No longer excluding colors.txt from project in Xcode * Add alternate body text color * Adding content / food enum for testing * Display contents in detail view * Further abstract contents list creation and add unit test * Refactor contents list to be more reactive * Changes per PR review * Remove centeredLabel extension in favor of UILabelStyle additions * Use container stackView instead of spacingView
lokae0
added a commit
that referenced
this pull request
Jun 13, 2019
* Add content title and button to Details view (#60) * Added strings for 'Contents' on details view * Change simulated delay to 1.0 to be more noticable * Clarify presenting VM vs presented VM in comments * Added content list title and button to detail view * Add some breathing room to stackViews * Fix unit test timeout * Add Content model and list display (#63) * Abstract centered label, remove unnecessary button boilerplate, and add spacing view * No longer excluding colors.txt from project in Xcode * Add alternate body text color * Adding content / food enum for testing * Display contents in detail view * Further abstract contents list creation and add unit test * Refactor contents list to be more reactive * Changes per PR review * Remove centeredLabel extension in favor of UILabelStyle additions * Use container stackView instead of spacingView * Add Basic Food Table View (#66) * Add FoodTable class cluster * Populate basic tableView * Add tests for FoodTable * Per Swift4 convention, use AnyObject instead of class for protocol constraints * Per PR review, fix FoodVCFactoryProtocol conformance * Per PR review, rename FoodTable to FoodInfo * Per PR review, streamline DetailVM factory protocol parameter * Per PR review, make cell identifier local var * Per PR review, update foods dependency structure * PR cleanup * Per PR review, cleanup where Food is located
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Content protocol and an example conforming type. This will next be passed onto the presented table view via protocol. Included a list display transformation with unit test.
colors.txtis now part of the Xcode project, so the hex values can be modified within the editor.Also made some UI tweaks and code cleanup.
ps. if you want to keep the tone of the project serious, I'm happy to rename the Food enum & cases to something more boring. But then I'll tell your gf and she'll make fun of you