Add content title and button to Details view #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8chur
approved these changes
Jan 16, 2019
| @@ -14,8 +14,8 @@ extension DetailPresentingViewModel { | |||
| /// This action should be executed with a Bool indicating whether the presentation should be animated. | |||
| /// | |||
| /// - Parameter factory: A factory to be used to generate the presented view model. | |||
| /// - Parameter setupViewModel: This closure will be called with the presenting view model when a present action | |||
| /// is executed. Consumers can use this to observe changes to the presenting view model if necessary. | |||
| /// - Parameter setupViewModel: This closure will be called with the presented view model when a present action | |||
lokae0
added a commit
that referenced
this pull request
Jan 17, 2019
* Added strings for 'Contents' on details view * Change simulated delay to 1.0 to be more noticable * Clarify presenting VM vs presented VM in comments * Added content list title and button to detail view * Add some breathing room to stackViews * Fix unit test timeout
lokae0
added a commit
that referenced
this pull request
Jan 28, 2019
* Added strings for 'Contents' on details view * Change simulated delay to 1.0 to be more noticable * Clarify presenting VM vs presented VM in comments * Added content list title and button to detail view * Add some breathing room to stackViews * Fix unit test timeout
lokae0
added a commit
that referenced
this pull request
Jun 13, 2019
* Add content title and button to Details view (#60) * Added strings for 'Contents' on details view * Change simulated delay to 1.0 to be more noticable * Clarify presenting VM vs presented VM in comments * Added content list title and button to detail view * Add some breathing room to stackViews * Fix unit test timeout * Add Content model and list display (#63) * Abstract centered label, remove unnecessary button boilerplate, and add spacing view * No longer excluding colors.txt from project in Xcode * Add alternate body text color * Adding content / food enum for testing * Display contents in detail view * Further abstract contents list creation and add unit test * Refactor contents list to be more reactive * Changes per PR review * Remove centeredLabel extension in favor of UILabelStyle additions * Use container stackView instead of spacingView * Add Basic Food Table View (#66) * Add FoodTable class cluster * Populate basic tableView * Add tests for FoodTable * Per Swift4 convention, use AnyObject instead of class for protocol constraints * Per PR review, fix FoodVCFactoryProtocol conformance * Per PR review, rename FoodTable to FoodInfo * Per PR review, streamline DetailVM factory protocol parameter * Per PR review, make cell identifier local var * Per PR review, update foods dependency structure * PR cleanup * Per PR review, cleanup where Food is located
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental PR to add a new title and button to the details view.
Will eventually lead to a ContentsTableViewController.
Also included some small updates that seemed apt to me (happy to revert if not).
Note- this is going into a feature branch, and not
master.