example to show correct iroh get behaviour
#339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start work on a streaming get API
Turns out we can use async_trait for the ApiExt trait
This fixes the bug I introduced by my wrong assumption what about get_stream produces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@faassen the last commit here takes your work and adds back in the correct behavior when using the
outpathand when using nested ipfs paths!iroh get Qmfoosaves the output of
QmfootoQmfooiroh get Qmfoo new_filesaves the output of
Qmfootonew_fileiroh get Qmfoo/barsaves the output of
Qmfoo/barto./bariroh get Qmfoo/bar new_filesaves the output of
Qmfoo/bartonew_fileNOTE:
I couldn't figure out exactly what the fixtures and tests were asking for.
I also was just a bit confused about the output for the tests anyway, as I mention in #331 (comment)