Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example to show correct iroh get behaviour #339

Closed
wants to merge 19 commits into from
Closed

example to show correct iroh get behaviour #339

wants to merge 19 commits into from

Commits on Oct 13, 2022

  1. Go from async_trait to being explicit 

    Start work on a streaming get API
    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e996b8d View commit details
    Browse the repository at this point in the history

  2. Bring save_get_stream under test

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    1a57651 View commit details
    Browse the repository at this point in the history

  3. Getting the fixture to produce the stream now

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    22f5d04 View commit details
    Browse the repository at this point in the history

  4. Clean up moving api ext into its own module 

    Turns out we can use async_trait for the ApiExt trait
    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    edf1fc6 View commit details
    Browse the repository at this point in the history

  5. get now returns the root path

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7d445da View commit details
    Browse the repository at this point in the history

  6. Use new cid method on ipfs path

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f3a7735 View commit details
    Browse the repository at this point in the history

  7. we can now test file output with trycmd!

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    90af754 View commit details
    Browse the repository at this point in the history

  8. Slightly better names

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7c86d4f View commit details
    Browse the repository at this point in the history

  9. Test for case where we have an explicit path

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    0912866 View commit details
    Browse the repository at this point in the history

  10. We now fail if the output path already exists

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7248190 View commit details
    Browse the repository at this point in the history

  11. We fail if we try to overwrite a named directory

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    2f6efba View commit details
    Browse the repository at this point in the history

  12. The relative-path dependency only is needed in the testing feature

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    92712db View commit details
    Browse the repository at this point in the history

  13. Rename away from foo as that's in .gitignore!

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    2548c59 View commit details
    Browse the repository at this point in the history

  14. The behavior is now to produce relative paths, which may be empty 

    This fixes the bug I introduced by my wrong assumption what about get_stream produces
    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    febaf4d View commit details
    Browse the repository at this point in the history

  15. A test for a wrapped file

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    42a66db View commit details
    Browse the repository at this point in the history

  16. Test the unwrapped file scenario

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d9c9a44 View commit details
    Browse the repository at this point in the history

  17. Overwriting single files isn't allowed either

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    fe7ef9d View commit details
    Browse the repository at this point in the history

  18. Lifetime elision is possible here

    @faassen
    faassen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d3fb9b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. fix: output path behaviours

    @ramfox
    ramfox committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    5fd1414 View commit details
    Browse the repository at this point in the history