refactor(iroh-net): Remove manual struct logging #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was essentially re-implementing the Rust Debug trait. Now that DerpUrl has a nice Debug log there really is no need to manually implement this, instead we rely on Debug.
dignifiedquire
approved these changes
Feb 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
## Description This was essentially re-implementing the Rust Debug trait. Now that DerpUrl has a nice Debug log there really is no need to manually implement this, instead we rely on Debug. ## Notes & open questions This is splitting off some peripheral stuff from n0-computer#1984 New flaky test marked: n0-computer#2010 and n0-computer#1935 ## Change checklist - [x] Self-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was essentially re-implementing the Rust Debug trait. Now that
DerpUrl has a nice Debug log there really is no need to manually
implement this, instead we rely on Debug.
Notes & open questions
This is splitting off some peripheral stuff from
#1984
New flaky test marked: #2010 and #1935
Change checklist