Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iroh-gossip: gossip_net_smoke sometimes does not finish #2010

Closed
flub opened this issue Feb 8, 2024 · 1 comment
Closed

iroh-gossip: gossip_net_smoke sometimes does not finish #2010

flub opened this issue Feb 8, 2024 · 1 comment
Labels
flaky-test

Comments

@flub
Copy link
Contributor

flub commented Feb 8, 2024

Observed at least on windows:

https://github.com/n0-computer/iroh/actions/runs/7828527174/job/21358602619
@flub flub added the flaky-test label Feb 8, 2024
@flub flub added this to iroh Feb 8, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in iroh Feb 8, 2024
@flub flub mentioned this issue Feb 8, 2024
Merged
1 task
@flub
Copy link
Contributor Author

flub commented Feb 8, 2024

Seems like this is a dup of #1975

@flub flub closed this as completed Feb 8, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh Feb 8, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 8, 2024
@flub
refactor(iroh-net): Remove manual struct logging (#2009)
315032a 
## Description

This was essentially re-implementing the Rust Debug trait.  Now that
DerpUrl has a nice Debug log there really is no need to manually
implement this, instead we rely on Debug.


## Notes & open questions

This is splitting off some peripheral stuff from
#1984

New flaky test marked: #2010
and #1935

## Change checklist

- [x] Self-review.
fubuloubu pushed a commit to ApeWorX/iroh that referenced this issue Feb 21, 2024
@flub @fubuloubu
refactor(iroh-net): Remove manual struct logging (n0-computer#2009)
fbc0c4b 
## Description

This was essentially re-implementing the Rust Debug trait.  Now that
DerpUrl has a nice Debug log there really is no need to manually
implement this, instead we rely on Debug.


## Notes & open questions

This is splitting off some peripheral stuff from
n0-computer#1984

New flaky test marked: n0-computer#2010
and n0-computer#1935

## Change checklist

- [x] Self-review.
rklaehn pushed a commit to n0-computer/iroh-blobs that referenced this issue Oct 22, 2024
@flub
refactor(iroh-net): Remove manual struct logging (#2009)
0e104bf 
## Description

This was essentially re-implementing the Rust Debug trait.  Now that
DerpUrl has a nice Debug log there really is no need to manually
implement this, instead we rely on Debug.


## Notes & open questions

This is splitting off some peripheral stuff from
n0-computer/iroh#1984

New flaky test marked: n0-computer/iroh#2010
and #1935

## Change checklist

- [x] Self-review.
dignifiedquire pushed a commit to n0-computer/iroh-gossip that referenced this issue Oct 23, 2024
@flub
refactor(iroh-net): Remove manual struct logging (#2009)
6853bed 
## Description

This was essentially re-implementing the Rust Debug trait.  Now that
DerpUrl has a nice Debug log there really is no need to manually
implement this, instead we rely on Debug.


## Notes & open questions

This is splitting off some peripheral stuff from
n0-computer/iroh#1984

New flaky test marked: n0-computer/iroh#2010
and #1935

## Change checklist

- [x] Self-review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test
Projects
iroh
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flub