-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase timeouts for tests that are flaky on slow CI #2450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe log the time it took, so we can see a little better if this was really the issue and what variance is in these
Sure, we can add that, but will we ever read the logs of successful CI runs for these? Because logging the time doesn't help on the failed runs, right? We'd need something like "CI metrics collection" to actually make use of these numbers. For general variance, I'd say total test runtime is already good enough likely. |
Yeah, I agree this is not terribly effective. I don't care about it really. |
well I would look at it retrospectively, if this is close to the timeout often, or not |
Description
We have some tests that use timeouts to not wait infinitely for an event that might not be coming. These tests are flaky if the timeout is too low, especially on windows and likely if the machines are overworked. This PR increases these timeouts:
test_node_add_tagged_blob_event
from 1s to 10s (Fixes Flakey: node::tests::test_node_add_taggded_blob_event #2331)pkarr_publish_dns_resolve_*
tests from 2s to 10s (Fixes flaky test: iroh-net discovery::test_dns_pkarr::pkarr_publish_dns_discover #2221)Breaking Changes
Notes & open questions
Change checklist