fix(iroh-net): delays of non-stun probes for subsequent relays #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea of the probe plan is that first the STUN probes happen, if those don't work we add the other probes. However when there are multiple relay servers we accidentally started the subsequent probes for all but the first relay server too late. This makes sure to globally record when the last STUN probe was sent and re-uses this value for all the relay servers which are probed.
flub
changed the title
flub
changed the title
|
The tests marked flaky in here should be fixed by #2450, so if that gets merged first we'd have to remove the flaky markers from this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea of the probe plan is that first the STUN probes happen, if
those don't work we add the other probes. However when there are
multiple relay servers we accidentally started the subsequent probes
for all but the first relay server too late.
This makes sure to globally record when the last STUN probe was sent
and re-uses this value for all the relay servers which are probed.
Breaking Changes
Notes & open questions
Fixes #2444
See #2221 for flaky tests.
Change checklist
[ ] Documentation updates if relevant.[ ] All breaking changes documented.