Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test: test_download_via_relay_with_discovery #2453

Open
Frando opened this issue Jul 3, 2024 · 1 comment
Open

flaky test: test_download_via_relay_with_discovery #2453

Frando opened this issue Jul 3, 2024 · 1 comment

Comments

@Frando
Copy link
Member

Frando commented Jul 3, 2024

test_download_via_relay_with_discovery failed with Error: Failed to complete download

https://github.com/n0-computer/iroh/actions/runs/9774608684/job/26983236863#step:10:1485

Marked as flaky in #2450

@Frando
Copy link
Member Author

Frando commented Jul 3, 2024

The failure is here: https://github.com/n0-computer/iroh/blob/main/iroh/src/node.rs#L658

       let hash = node1.blobs().add_bytes(b"foo".to_vec()).await?.hash;

        // create a node addr with node id only
        let addr = NodeAddr::new(node1.node_id());
        node2.blobs().download(hash, addr).await?.await?;

I don't see a reason immediately why this may be flaky. There's no timeout, it uses a local relay, and the operation should be totally predictable. Maybe something about the timings about spawning and discovery being ready?

@ramfox ramfox moved this to 📋 Backlog in iroh Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant