Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor♻️]Refactor NotifyMinBrokerIdChangeRequestHeader with derive marco RequestHeaderCodec #1511

Closed
5 tasks
mxsm opened this issue Dec 2, 2024 · 0 comments · Fixed by #2316
Closed
5 tasks
Labels
Difficulty level/Easy Easy ISSUE good first issue Good for newcomers help wanted Extra attention is needed refactor♻️ refactor code
Milestone

Comments

@mxsm
Copy link
Owner

mxsm commented Dec 2, 2024

Which part of the code will be refactored?

No response

What problems does the refactor aim to solve?

Refactor example:

#[derive(Debug, Clone, Serialize, Deserialize, Default, RequestHeaderCodec)]
#[serde(rename_all = "camelCase")]
pub struct SendMessageRequestHeader {
#[required]
pub producer_group: CheetahString,
#[required]
pub topic: CheetahString,
#[required]
pub default_topic: CheetahString,
#[required]
pub default_topic_queue_nums: i32,
#[required]
pub queue_id: Option<i32>,
#[required]
pub sys_flag: i32,
#[required]
pub born_timestamp: i64,
#[required]
pub flag: i32,
pub properties: Option<CheetahString>,
pub reconsume_times: Option<i32>,
pub unit_mode: Option<bool>,
pub batch: Option<bool>,
pub max_reconsume_times: Option<i32>,
#[serde(flatten)]
pub topic_request_header: Option<TopicRequestHeader>,
}

Do you have any specific design or implementation considerations?

No response

Is there a related issue or PR?

No response

Checklist

  • Ensure the refactor does not introduce new bugs

  • Update unit tests if applicable

  • Ensure the refactor does not negatively impact performance

  • Document any new patterns or architecture changes

  • Test the refactor in different environments (e.g., staging, production)

@mxsm mxsm added help wanted Extra attention is needed good first issue Good for newcomers refactor♻️ refactor code labels Dec 2, 2024
@RocketmqRustBot RocketmqRustBot added this to the v0.4.0 milestone Dec 2, 2024
@mxsm mxsm added the Difficulty level/Easy Easy ISSUE label Dec 17, 2024
mxsm added a commit that referenced this issue Jan 18, 2025
rocketmq-rust-bot pushed a commit that referenced this issue Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty level/Easy Easy ISSUE good first issue Good for newcomers help wanted Extra attention is needed refactor♻️ refactor code
Projects
None yet
2 participants