fairly comprehensive reorg #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memcpy wasn't working for some reason.. I think I must have misunderstood the type of the storage() or something
There were two issues: * apparently linking share libraries together into a single shared library is not a good thing to do, so we keep things as "relocatable object files" and compile those into a shared library * I think there were two copies of my package floating around on Travis and one was getting built, the other was getting tested, so just use the default testing script
TODO: split src/measures/measures.jl into several files
and fix up math with measures
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 98.14% 97.77% -0.38%
==========================================
Files 3 15 +12
Lines 270 360 +90
==========================================
+ Hits 265 352 +87
- Misses 5 8 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tidies up the code, fixes a few outstanding bugs, and makes this package usable with Julia v0.6.
lock/unlockfunctions in favor ofopen/closeand the automaticread/writelocks that casacore does for tables by default)