Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtable keywords are broken #62

Closed
mweastwood opened this issue Oct 28, 2016 · 0 comments · Fixed by #68
Closed

subtable keywords are broken #62

mweastwood opened this issue Oct 28, 2016 · 0 comments · Fixed by #68

Comments

@mweastwood
Copy link
Owner

When I switched from wrapping TableProxy to just regular Table, I missed a conversion that TableProxy was doing automatically. I mistakenly assumed Table would do the same thing.

When reading a keyword, TableProxy does the following if the keyword points to another table.

  ...
  case TpTable:
    return ValueHolder ("Table: "+keySet.tableAttributes(fieldId).name());
  ...

Because I'm now wrapping Table, I could probably just return the actual Table object itself, which seems like the sensible thing to do. However at the moment it is just broken because I haven't defined a wrapper function for the case where the data type is TpTable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant