Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dodging with interval marks #2922

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Fix dodging with interval marks #2922

merged 1 commit into from
Jul 26, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jul 25, 2022

See #2912 for an example of this not working properly.

Fixed:

(
    so.Plot(tips, "day", "total_bill", color="smoker")
    .add(so.Bar(fill=False, edgewidth=2), so.Agg(), so.Dodge())
    .add(so.Interval(linewidth=2), so.Est(), so.Dodge())
)

image

@mwaskom mwaskom added this to the v0.12.0 milestone Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #2922 (0cf08d8) into master (34662f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2922   +/-   ##
=======================================
  Coverage   98.23%   98.24%           
=======================================
  Files          69       69           
  Lines       22856    22866   +10     
=======================================
+ Hits        22453    22464   +11     
+ Misses        403      402    -1     
Impacted Files Coverage Δ
seaborn/_core/plot.py 95.52% <100.00%> (+0.14%) ⬆️
tests/_core/test_plot.py 98.51% <100.00%> (+0.01%) ⬆️

@mwaskom mwaskom merged commit 36cc26b into master Jul 26, 2022
@mwaskom mwaskom deleted the move/grouping branch August 6, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant