-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Est stat and Interval mark to show error bars #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's something that needs to be addressed: (
so.Plot(penguins, x="bill_length_mm", y="species", color="sex")
.add(so.Interval(), so.Est(), so.Dodge())
.add(so.Dot(), so.Agg(), so.Dodge())
) This is because (
so.Plot(penguins, x="bill_length_mm", y="species", color="sex")
.add(so.Interval(), so.Est(), so.Dodge(by=["color"]))
.add(so.Dot(), so.Agg(), so.Dodge())
) But this needs a cleaner solution (cf #2894) |
Codecov Report
@@ Coverage Diff @@
## master #2912 +/- ##
==========================================
+ Coverage 98.20% 98.22% +0.01%
==========================================
Files 69 69
Lines 22666 22822 +156
==========================================
+ Hits 22260 22416 +156
Misses 406 406
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new mark and a new stat that together will add error bars to aggregations:
The
Est
stay has the same basic API for error bar selection as we'll be rolling out for the functional interface in 0.12 (i.e.,ci
/se
/pi
/sd
, with an optional scale/level parameter.Note that is currently necessary to add two layers to get a dot + interval; see #2911 for some ideas there
This PR also addresses some wrinkles relating to matplotlib capstyles in both the interval mark and existing line marks.