Change Area/Ribbon to generate Polygon patches and add clipping trick #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2896 +/- ##
==========================================
- Coverage 98.20% 98.20% -0.01%
==========================================
Files 69 69
Lines 22561 22585 +24
==========================================
+ Hits 22156 22179 +23
- Misses 405 406 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
AreageneratedPolyCollectionartists to match whatax.fill_betweendoes, but I don't think it would be very common to need to extra speed you get with that for this type of mark, and thePolygonpatch artist is easier to work with.This PR also adds in (copies — blegh) the artist clipping and sticky edges previously applied to Bar marks (#2889).
Closes #2890