Improve visual appearance of Bar mark #2889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks here:
The third tweak is the most interesting think here, although I am somewhat concerned it will cause problems in the future and I am thinking of it as an experimental solution for now. The idea is to avoid the effect that you get at the interface of dodged or stacked bars with nontrivial edge widths:
Old:
New:
One aspect of the implementation that I don't love is the need to double the internal linewidth and half the dashes (when present). That could cause some unpleasant surprises when working with the artists directly, but I am not certain how to work around it.