-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lageanes dialects #74
Conversation
This pull request is automatically deployed with Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @mauscoelho thanks for contributing!!
I think PR It fits in the state of Santa Catarina
because Lages
is a municipality.
What do you think?
So, that's a really good topic 😂 There are some types of dialects in Santa Catarina and they are really different. One of them is the As you can see on the image below, the But, is up to you to. If you prefer I merge it as a general dialect of the state of Santa Catarina |
Hi @mvfsillva, it's a great project, congrats! I think the better approach is they cannot be considered state dialects, once there usually is more than one dialect per state. (Only a suggest) |
Guys this is amazing!That is the idea of this project, the Brazilian cultural wealth is incredible, I did not imagine these divisions, let's improve! Let's add a new node in this |
Yes, for sure!
|
Hey @mauscoelho, Thanks for contributing!! I think you can use this format:
I believe this is the better way to limit a dialect by zone. |
@RodolfoSilva Lages is the city if we follow this pattern I should add 23 cities on the node 🤔 according to wikipedia. I think the better way is to group by state :) what do you think @mvfsillva ? |
Hi guys I think this PR should propose a major change in the file structure of dialects because we understand that the dialect can cross the state boundaries. For example, "Gringonês" can be seen in Xanxerê (SC) as well as in Erechim (RS), as well as "Lageanês" can be seen in Lages (SC) and in Vacaria (RS). Therefore, I recommend the following structure:
I know, this has a big impact. 😬 |
Could you open an issue so we can discuss it? |
Initially, I think it is best to group by states |
I'm going to merge your pr and open an issue so we can think together about a better solution! What do you think? |
Description
This PR adds the dialects that come from the city of Lages and Amures region