Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scripts & documentation for the SC calls executor #412

Merged
merged 9 commits into from
Jan 22, 2025

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Jan 17, 2025

  • added scripts for the SC calls executor
  • added documentation for the SC calls executor
  • fixed the flag for providing sc proxy addresses
  • added CLI.md file & the generating script

@iulianpascalau iulianpascalau marked this pull request as draft January 17, 2025 08:29
@iulianpascalau iulianpascalau changed the title [WIP]Adding scripts & documentation for the SC calls executor Adding scripts & documentation for the SC calls executor Jan 21, 2025
@iulianpascalau iulianpascalau marked this pull request as ready for review January 21, 2025 15:22
valentin-lup
valentin-lup previously approved these changes Jan 22, 2025
Copy link
Contributor

@valentin-lup valentin-lup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scripts & docs reviewed.

Makefile Outdated
echo "Error - please update all CLI.md files by running the 'cli-docs' or 'check-cli-md' from Makefile!"; \
exit 1; \
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Makefile Outdated
Comment on lines 42 to 43
cd ./cmd && bash ./CLI.md.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be reused cli-docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reused


GLOBAL OPTIONS:
--working-directory directory This flag specifies the directory where the node will store databases and logs.
--log-level level(s) This flag specifies the logger level(s). It can contain multiple comma-separated value. For example, if set to *:INFO the logs for all packages will have the INFO level. However, if set to *:INFO,api:DEBUG the logs for all packages will have the INFO level, excepting the api package which will receive a DEBUG log level. (default: "*:DEBUG")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--log-level level(s) This flag specifies the logger level(s). It can contain multiple comma-separated value. For example, if set to *:INFO the logs for all packages will have the INFO level. However, if set to *:INFO,api:DEBUG the logs for all packages will have the INFO level, excepting the api package which will receive a DEBUG log level. (default: "*:DEBUG")
--log-level level(s) This flag specifies the logger level(s). It can contain multiple comma-separated values. For example, if set to *:INFO the logs for all packages will have the INFO level. However, if set to *:INFO,api:DEBUG the logs for all packages will have the INFO level, excepting the api package which will receive a DEBUG log level. (default: "*:DEBUG")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

--working-directory directory This flag specifies the directory where the node will store databases and logs.
--log-level level(s) This flag specifies the logger level(s). It can contain multiple comma-separated value. For example, if set to *:INFO the logs for all packages will have the INFO level. However, if set to *:INFO,api:DEBUG the logs for all packages will have the INFO level, excepting the api package which will receive a DEBUG log level. (default: "*:DEBUG")
--disable-ansi-color Boolean option for disabling ANSI colors in the logging system.
--config [path] The [path] for the main configuration file. This TOML file contain the main configurations such as monitored SC, gateway URL, timings and so on (default: "config/config.toml")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--config [path] The [path] for the main configuration file. This TOML file contain the main configurations such as monitored SC, gateway URL, timings and so on (default: "config/config.toml")
--config [path] The [path] for the main configuration file. This TOML file contains the main configurations such as monitored SC, gateway URL, timings and so on (default: "config/config.toml")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

throttling might occur without the access token.

The `EXTRA_FLAGS` can contain extra flags to be called whenever the application is started.
The complete list of the cli command can be found [here](./cmd/scCallsExecutor/CLI.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The complete list of the cli command can be found [here](./cmd/scCallsExecutor/CLI.md)
The complete list of the cli commands can be found [here](./cmd/scCallsExecutor/CLI.md).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

HUMAN_TIME=$(date -d @"$GITHUB_API_RESET")

# Allow user to override the current version to be used
OVERRIDE_VER=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@iulianpascalau iulianpascalau merged commit 19ff0a0 into feat/v3.1 Jan 22, 2025
4 checks passed
@iulianpascalau iulianpascalau deleted the scripts-docs-sc-calls-executor branch January 22, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants