Skip to content

Commit

Permalink
- fixes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
iulianpascalau committed Jan 22, 2025
1 parent 026a2be commit a64c3b2
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 10 deletions.
6 changes: 2 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,10 @@ cli-docs:
cd ./cmd/scCallsExecutor && go build
cd ./cmd && bash ./CLI.md.sh

check-cli-md:
cd ./cmd/scCallsExecutor && go build
cd ./cmd && bash ./CLI.md.sh
check-cli-md: cli-docs
@status=$$(git status --porcelain | grep CLI); \
if [ ! -z "$${status}" ]; \
then \
echo "Error - please update all CLI.md files by running the 'cli-docs' or 'check-cli-md' from Makefile!"; \
exit 1; \
fi
fi
4 changes: 2 additions & 2 deletions cmd/scCallsExecutor/CLI.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ COMMANDS:
GLOBAL OPTIONS:
--working-directory directory This flag specifies the directory where the node will store databases and logs.
--log-level level(s) This flag specifies the logger level(s). It can contain multiple comma-separated value. For example, if set to *:INFO the logs for all packages will have the INFO level. However, if set to *:INFO,api:DEBUG the logs for all packages will have the INFO level, excepting the api package which will receive a DEBUG log level. (default: "*:DEBUG")
--log-level level(s) This flag specifies the logger level(s). It can contain multiple comma-separated values. For example, if set to *:INFO the logs for all packages will have the INFO level. However, if set to *:INFO,api:DEBUG the logs for all packages will have the INFO level, excepting the api package which will receive a DEBUG log level. (default: "*:DEBUG")
--disable-ansi-color Boolean option for disabling ANSI colors in the logging system.
--config [path] The [path] for the main configuration file. This TOML file contain the main configurations such as monitored SC, gateway URL, timings and so on (default: "config/config.toml")
--config [path] The [path] for the main configuration file. This TOML file contains the main configurations such as monitored SC, gateway URL, timings and so on (default: "config/config.toml")
--log-save Boolean option for enabling log saving. If set, it will automatically save all the logs into a file.
--log-logger-name Boolean option for logger name in the logs.
--profile-mode Boolean option for enabling the profiling mode. If set, the /debug/pprof routes will be available on the node for profiling the application.
Expand Down
2 changes: 1 addition & 1 deletion cmd/scCallsExecutor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ It is strongly recommended to use a GitHub access token because the scripts cons
throttling might occur without the access token.

The `EXTRA_FLAGS` can contain extra flags to be called whenever the application is started.
The complete list of the cli command can be found [here](./cmd/scCallsExecutor/CLI.md)
The complete list of the cli commands can be found [here](./cmd/scCallsExecutor/CLI.md)

The `OVERRIDE_VER` can be used during testing to manually specify an override tag/branch that will be used when building
the application. If left empty, the upgrade process will automatically fetch and use the latest release.
Expand Down
4 changes: 2 additions & 2 deletions cmd/scCallsExecutor/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
var (
logLevel = cli.StringFlag{
Name: "log-level",
Usage: "This flag specifies the logger `level(s)`. It can contain multiple comma-separated value. For example" +
Usage: "This flag specifies the logger `level(s)`. It can contain multiple comma-separated values. For example" +
", if set to *:INFO the logs for all packages will have the INFO level. However, if set to *:INFO,api:DEBUG" +
" the logs for all packages will have the INFO level, excepting the api package which will receive a DEBUG" +
" log level.",
Expand All @@ -19,7 +19,7 @@ var (
// configurationFile defines a flag for the path to the main toml configuration file
configurationFile = cli.StringFlag{
Name: "config",
Usage: "The `" + filePathPlaceholder + "` for the main configuration file. This TOML file contain the main " +
Usage: "The `" + filePathPlaceholder + "` for the main configuration file. This TOML file contains the main " +
"configurations such as monitored SC, gateway URL, timings and so on",
Value: "config/config.toml",
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/scCallsExecutor/config/variables.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ GITHUB_API_RESET=$(echo $GITHUB_RATE_LIMIT_RESPONSE | jq -r .resources.core.rese
HUMAN_TIME=$(date -d @"$GITHUB_API_RESET")

# Allow user to override the current version to be used
OVERRIDE_VER=""
OVERRIDE_VER=""

0 comments on commit a64c3b2

Please sign in to comment.