Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a codepoint for plaintextv2 #222

Merged
merged 1 commit into from
Sep 20, 2021
Merged

add a codepoint for plaintextv2 #222

merged 1 commit into from
Sep 20, 2021

Conversation

marten-seemann
Copy link
Contributor

Analogous to #221.

As we want to stop negotiating security protocols, we'll also need a codepoint for insecure connections. Example: /ip4/1.2.3.4/tcp/4001/insecure.

@Stebalien
Copy link
Member

Do we? This is for testing only and we'll need to support security transport negotiation for the foreseeable future anyways.

Stebalien
Stebalien approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so this is a real protocol and it does make sense to support it. But let's put it in the three byte range.

mxinden
mxinden previously requested changes Jul 5, 2021
View reviewed changes
table.csv Outdated Show resolved Hide resolved
@marten-seemann
Copy link
Contributor Author

I renamed the protocol to plaintextv2, and assigned a 3-byte code-point (PLA in ASCII, sorry for not being more creative).

@marten-seemann marten-seemann mentioned this pull request Sep 19, 2021
Merged
@marten-seemann marten-seemann changed the title add an insecure codepoint add a codepoint for plaintextv2 Sep 19, 2021
@marten-seemann marten-seemann merged commit aee7473 into master Sep 20, 2021
mxinden
mxinden reviewed Sep 26, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marten-seemann @Stebalien @mxinden