Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose LDFLAGS to all processes, and using it for stripping #329

Closed
wants to merge 1 commit into from

Conversation

seiko2plus
Copy link

Expose LDFLAGS to all processes, and using it for stripping

@mattip
Copy link
Collaborator

mattip commented May 6, 2020

This overrides values of the variables with... values of the variables? Is there a test you can add that proves this changes something?

@seiko2plus
Copy link
Author

seiko2plus commented May 6, 2020

@mattip, that's not overriding it's just taking local variable and expose it to all child processes so it can be visible to python

@@ -39,9 +40,10 @@ else
# Strip all binaries after compilation.
STRIP_FLAGS=${STRIP_FLAGS:-"-Wl,-strip-all"}
Copy link
Author

@seiko2plus seiko2plus May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to replace the default stripping to "-Wl,-strip-debug", in order to leave the default ELF sections untouched

@seiko2plus
Copy link
Author

@mattip, I will test it manually

@mattip
Copy link
Collaborator

mattip commented May 6, 2020

MacPython/numpy-wheels#87 proved that export LDFLAGS="$LDFLAGS" actually does something, sorry for doubting. Here is a stack overflow that says what you said above:

If you want a process to make use of this variable, use export, and run the process from that shell.

@seiko2plus
Copy link
Author

seiko2plus commented May 6, 2020

@mattip, you have nothing to be sorry for, doubting is always part of the development process. :), I did a manual test and it seems good to me.

@seiko2plus seiko2plus closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants