Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Append flags #86

Merged
merged 3 commits into from
May 6, 2020
Merged

Append flags #86

merged 3 commits into from
May 6, 2020

Conversation

mattip
Copy link
Contributor

@mattip mattip commented May 6, 2020

Replaces gh-82 : we should strip the linux binaries before shipping.

Issue gh-19 assumed that we do not override CFLAGS, but we do. Using a branch on a fork so successful builds are not uploaded

@mattip mattip mentioned this pull request May 6, 2020
@charris charris merged commit 1c7c0dd into MacPython:master May 6, 2020
@charris
Copy link
Contributor

charris commented May 6, 2020

Thanks Matti. There were no uploads, so that worked. Should we add back the -msse2 flags?

@mattip
Copy link
Contributor Author

mattip commented May 6, 2020

Should we add back the -msse2 flag

OK.

@mattip
Copy link
Contributor Author

mattip commented May 6, 2020

Hmm, it didn't work. The file sizes are the same.

@charris
Copy link
Contributor

charris commented May 6, 2020

Looks like the manylinux2010 files are a lot bigger than manylinux1 files. Do they have an extra fortran library?

@charris
Copy link
Contributor

charris commented May 6, 2020

There is no OpenBLAS in the manylinux1 wheels.

@charris
Copy link
Contributor

charris commented May 6, 2020

Maybe we need to strip the OpenBLAS libraries. Do we want to do that?

@mattip
Copy link
Contributor Author

mattip commented May 6, 2020

There is no OpenBLAS in the manylinux1 wheels.

Whoops. numpy/numpy#16171

@mattip
Copy link
Contributor Author

mattip commented May 6, 2020

Maybe we need to strip the OpenBLAS libraries. Do we want to do that?

I think they are pretty good. strip -g didn't remove anything, strip -s reduced the 18.3 one from 29 to 28MB.

@seiko2plus
Copy link
Contributor

@mattip, I checked build logs, and I found that LDFLAGS isn't exposed to all processes which make it invisible to distutils. xref matthew-brett/multibuild#329

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants