Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Polish on the bug issue template #5525

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

oliviertassinari
Copy link
Member

A quick follow-up on #5067, tackling the points raised.

@oliviertassinari oliviertassinari marked this pull request as ready for review July 17, 2022 18:24
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jul 17, 2022
@@ -9,7 +9,7 @@
/r/x-license-key-installation https://mui.com/x/introduction/licensing/#license-key-installation 302
/r/x-data-grid-no-dimensions https://mui.com/x/react-data-grid/layout/ 302
/r/x-technical-support https://mui.com/x/introduction/support/#technical-support 302
/r/x-issue-template https://codesandbox.io/s/mui-x-issue-template-uh3pm2 302
/r/x-issue-template https://codesandbox.io/s/mui-x-issue-template-qtf00h 302
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the console warning, and bring the codesandbox to the MUI org.

@@ -39,8 +39,8 @@ Find more details [in the docs](https://mui.com/x/introduction/licensing/).
## Questions

For _how-to_ questions and other non-issues,
please use [StackOverflow](https://stackoverflow.com/questions/tagged/mui) instead of GitHub issues.
There is a StackOverflow tag called "mui" that you can use to tag your questions.
please use [Stack Overflow](https://stackoverflow.com/questions/tagged/mui) instead of GitHub issues.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was simply wrong spelling.


As a starting point, we recommend you [browse the documentation](https://mui.com/x/introduction/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply Matt's feedback and fix 301

@mui-bot
Copy link

mui-bot commented Jul 17, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 293 912.6 382.2 518.62 233.017
Sort 100k rows ms 664.9 1,433.7 1,433.7 1,052.08 287.929
Select 100k rows ms 211.2 378.5 257.3 277.74 56.128
Deselect 100k rows ms 154.3 485.5 285.2 281.38 119.137

Generated by 🚫 dangerJS against 89ae5ef

@oliviertassinari oliviertassinari merged commit 964d75e into mui:master Jul 18, 2022
@oliviertassinari oliviertassinari deleted the issue-template-polish branch July 18, 2022 21:24
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants